Skip to content

Update Drawer tests for M2/M3 #135752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2023
Merged

Update Drawer tests for M2/M3 #135752

merged 1 commit into from
Sep 29, 2023

Conversation

TahaTesser
Copy link
Member

Updated unit tests for Drawer to have M2 and M3 versions.

More info in #127064

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 29, 2023
QuncCccccc
QuncCccccc approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for continuing to add tests for M2&M3!

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2023
@auto-submit auto-submit bot merged commit ebaf160 into flutter:master Sep 29, 2023
@TahaTesser TahaTesser deleted the update_drawer_tests branch September 29, 2023 18:20
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2023
@engine-flutter-autoroll
ebaf160 Update Drawer tests for M2/M3 (flutter/flutter#135752)
01206dc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2023
@engine-flutter-autoroll
ebaf160 Update Drawer tests for M2/M3 (flutter/flutter#135752)
90bad6d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 30, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2023
@engine-flutter-autoroll
ebaf160 Update Drawer tests for M2/M3 (flutter/flutter#135752)
c3cf6fa
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 30, 2023
@engine-flutter-autoroll
Roll Flutter from 57b5c3c to d3df8f6 (24 revisions) (#5043)
e5fedee 
flutter/flutter@57b5c3c...d3df8f6

2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 68fc1a567195 to 01fc3c6624ce (1 revision) (flutter/flutter#135808)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4ed733d99cd5 to 68fc1a567195 (1 revision) (flutter/flutter#135807)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from d814c69abe26 to 4ed733d99cd5 (1 revision) (flutter/flutter#135801)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from f726438d4d65 to d814c69abe26 (1 revision) (flutter/flutter#135799)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0b96a82cc874 to f726438d4d65 (1 revision) (flutter/flutter#135796)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from f3a4cab69962 to 0b96a82cc874 (1 revision) (flutter/flutter#135793)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from e719b7957763 to f3a4cab69962 (2 revisions) (flutter/flutter#135792)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8939f9c1f4e4 to e719b7957763 (2 revisions) (flutter/flutter#135789)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6a13607008ed to 8939f9c1f4e4 (1 revision) (flutter/flutter#135788)
2023-09-30 32242716+ricardoamador@users.noreply.github.com Add device ready check (flutter/flutter#135526)
2023-09-30 32242716+ricardoamador@users.noreply.github.com Temporarily disable NexusLowRes, version=29 (flutter/flutter#135785)
2023-09-30 sokolovskyi.konstantin@gmail.com Cover more test/widgets tests with leak tracking #12. (flutter/flutter#135385)
2023-09-30 sokolovskyi.konstantin@gmail.com DraggableScrollableController should dispatch creation in constructor. (flutter/flutter#135423)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from d203e349781c to 6a13607008ed (2 revisions) (flutter/flutter#135780)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 48973d7f9beb to d203e349781c (5 revisions) (flutter/flutter#135776)
2023-09-29 sokolovskyi.konstantin@gmail.com ViewportOffset should dispatch creation in constructor. (flutter/flutter#135420)
2023-09-29 jacksongardner@google.com Use platform dill from the engine when compiling with dart2wasm. (flutter/flutter#134970)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from d5fcd78a879b to 48973d7f9beb (5 revisions) (flutter/flutter#135765)
2023-09-29 polinach@google.com Upgrade leak_tracker to fix flackiness. (flutter/flutter#135760)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from c52251a8b2d0 to d5fcd78a879b (2 revisions) (flutter/flutter#135755)
2023-09-29 tessertaha@gmail.com Update `Drawer` tests for M2/M3 (flutter/flutter#135752)
2023-09-29 katelovett@google.com Expose onAttach and onDetach in ScrollController subclasses (flutter/flutter#135721)
2023-09-29 jacksongardner@google.com Update the wasm bootstrap to allow access to the emscripten wrapper to skwasm. (flutter/flutter#135723)
2023-09-29 42216813+eliasyishak@users.noreply.github.com Update logic for getting `Analytics` instance from package:unified_analytics (flutter/flutter#134756)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@TahaTesser @Mairramer
Update Drawer tests for M2/M3 (flutter#135752)
e3f9b7c 
Updated unit tests for `Drawer` to have M2 and M3 versions.

More info in flutter#127064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TahaTesser @QuncCccccc