Skip to content

Conversation

MitchellGoodwin
Copy link
Contributor

Separates the tests for the Material dialog into Material3 and Material2 versions.

More info in #127064

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 29, 2023
@TahaTesser TahaTesser self-requested a review October 2, 2023 10:53
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 2, 2023
@auto-submit auto-submit bot merged commit 57ed724 into flutter:master Oct 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 2, 2023
flutter/flutter@d42313c...57ed724

2023-10-02 58190796+MitchellGoodwin@users.noreply.github.com Update dialog tests for Material3 (flutter/flutter#135775)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1410d689bd0a to 321139f5821e (2 revisions) (flutter/flutter#135843)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8b63d286b51a to 1410d689bd0a (1 revision) (flutter/flutter#135840)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9ccf85f09e73 to 8b63d286b51a (1 revision) (flutter/flutter#135838)
2023-10-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 10b930ad1adf to 9ccf85f09e73 (1 revision) (flutter/flutter#135837)
2023-10-02 82763757+NobodyForNothing@users.noreply.github.com Test cover cupertino text field for memory leaks. (flutter/flutter#135804)
2023-10-02 sokolovskyi.konstantin@gmail.com Fix memory leaks in WidgetInspector and WidgetInspectorService. (flutter/flutter#135828)
2023-10-01 82763757+NobodyForNothing@users.noreply.github.com leak track page_test.dart (flutter/flutter#135352)
2023-10-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from fff38de45ef7 to 10b930ad1adf (1 revision) (flutter/flutter#135835)
2023-10-01 82763757+NobodyForNothing@users.noreply.github.com Leak track cupertino widgets (flutter/flutter#135353)
2023-10-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 310ad4666445 to fff38de45ef7 (1 revision) (flutter/flutter#135830)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
Separates the tests for the Material dialog into Material3 and Material2 versions.

More info in flutter#127064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants