Skip to content

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Nov 18, 2023

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Nov 18, 2023
@polina-c polina-c requested a review from jacob314 November 20, 2023 18:00
Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@polina-c
Copy link
Contributor Author

@godofredoc, can you review to make sure it is a right way to parameterize tests, to enable (1) use cases we discussed on Friday and (2) users to run with and without leak tracking?

@polina-c
Copy link
Contributor Author

@keyonghan

Co-authored-by: keyonghan <54558023+keyonghan@users.noreply.github.com>
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 22, 2023
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The env variable name LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants