Skip to content

Update labeler version, fix yaml to work with v5 #139564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2023
Merged

Update labeler version, fix yaml to work with v5 #139564

merged 3 commits into from
Dec 5, 2023

Conversation

drewroengoogle
Copy link
Contributor

@drewroengoogle drewroengoogle commented Dec 5, 2023 •
edited
Loading

This fixes #139511

  • A bug has been fixed with sync-labels, meaning this needs to be a boolean now. Setting to true to match v4 logic.
  • in labeler.yml, all labels must be a list of globs, so updated them all to be a list of any.
  • Update the version to v5

This is a little annoying to test, since the way github actions works means that changes to workflows aren't run until after they are merged. A workaround is I forked these labeler changes to a new branch in my own repo and created a PR to merge to that branch, seen here: https://github.com/drewroengoogle/flutter/actions/runs/7102118110/job/19331743809?pr=2. Note the step Run actions/labeler@8558fd74291d67161a8a78ce36a881fa63b766a9 which ensures we are running on the latest labeler version in that check.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@drewroengoogle drewroengoogle mentioned this pull request Dec 5, 2023
Closed
keyonghan
keyonghan approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drewroengoogle drewroengoogle added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 5, 2023
@auto-submit auto-submit bot merged commit a82ae23 into flutter:master Dec 5, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
86059c0 
…tter#139564)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
7ea6ec9 
…tter#139564)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
abaa015 
…tter#139564)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
6269e64 
…tter#139564)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
f463bcf 
…tter#139564)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
196c07b 
…tter#139564)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
20387a4 
…tter#139564)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
b3cea12 
…tter#139564)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
9b98d4b 
…tter#139564)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
7204c9a 
…tter#139564)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
b654e60 
…tter#139564)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
c0906ac 
…tter#139564)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
9d432ce 
…tter#139564)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
edd2cd7 
…tter#139564)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
bd7a8f9 
…tter#139564)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
a88c1c5 
…tter#139564)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
07d8f97 
…tter#139564)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
b76e3a9 
…tter#139564)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
e8b660c 
…tter#139564)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
92d5fb4 
…tter#139564)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
ca3d85e 
…tter#139564)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
29b78c9 
…tter#139564)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
fc44181 
…tter#139564)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
8fc643d 
…tter#139564)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
a82ae23 Update labeler version, fix yaml to work with v5 (flutter/flu…
ed6fe10 
…tter#139564)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

@ricardoamador ricardoamador Awaiting requested review from ricardoamador

@godofredoc godofredoc Awaiting requested review from godofredoc

1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

labeler action failing presubmit on schema error after dependabot roll

2 participants

@drewroengoogle @keyonghan