Skip to content

Remove usage of testWidgetsWithLeakTracking. #140239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 15, 2023
Merged

Remove usage of testWidgetsWithLeakTracking. #140239

merged 6 commits into from
Dec 15, 2023

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Dec 15, 2023 •
edited
Loading

Usage of testWidgetsWithLeakTracking should be removed in order to integrate leak tracking with testWidgets.
If testWidgetsWithLeakTracking coexists with the integration, it creates circular reference between leak_tracker and testWidgets, that we do not want.

Contributes to #135856

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository f: routes Navigator, Router, and related APIs. f: gestures flutter/packages/flutter/gestures repository. f: focus Focus traversal, gaining or losing focus labels Dec 15, 2023
dnfield
dnfield approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file an issue (or link to an existing one) and update the description about why this is happening/what the plan is going forward.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2023
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Dec 15, 2023

auto label is removed for flutter/flutter/140239, due to - The status or check suite Windows framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2023
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Dec 15, 2023

auto label is removed for flutter/flutter/140239, due to - The status or check suite Windows framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Mac framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2023
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2023
@polina-c polina-c mentioned this pull request Dec 15, 2023
Merged
1 task
@polina-c polina-c merged commit baf739c into flutter:master Dec 15, 2023
@polina-c polina-c deleted the remove branch December 15, 2023 22:13
@polina-c
Copy link
Contributor Author

Bypassed google3 testing, because status is no test needed and update of status fails.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2023
@engine-flutter-autoroll
baf739c Remove usage of testWidgetsWithLeakTracking. (flutter/flutter…
c3ebce4 
…#140239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2023
@engine-flutter-autoroll
baf739c Remove usage of testWidgetsWithLeakTracking. (flutter/flutter…
0065d0f 
…#140239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2023
@engine-flutter-autoroll
baf739c Remove usage of testWidgetsWithLeakTracking. (flutter/flutter…
d866b6b 
…#140239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2023
@engine-flutter-autoroll
baf739c Remove usage of testWidgetsWithLeakTracking. (flutter/flutter…
6f7ac9b 
…#140239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2023
@engine-flutter-autoroll
baf739c Remove usage of testWidgetsWithLeakTracking. (flutter/flutter…
1967be6 
…#140239)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2023
@engine-flutter-autoroll
baf739c Remove usage of testWidgetsWithLeakTracking. (flutter/flutter…
dc8bc18 
…#140239)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 18, 2023
@engine-flutter-autoroll
Roll Flutter from 2407f69 to cdc83e5 (28 revisions) (#5715)
be52ac8 
flutter/flutter@2407f69...cdc83e5

2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from b3de65a6d3ea to 7f1a81d5545a (1 revision) (flutter/flutter#140309)
2023-12-18 raphire08@users.noreply.github.com refactored cli tool ipa method name to support --export-options-plist (flutter/flutter#138555)
2023-12-18 andrewrkolos@gmail.com Restore and fix flavors_test_macos (flutter/flutter#139841)
2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 626c93260f79 to b3de65a6d3ea (1 revision) (flutter/flutter#140308)
2023-12-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from f9c7aa27f13a to 626c93260f79 (1 revision) (flutter/flutter#140291)
2023-12-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 726a137e3f99 to f9c7aa27f13a (1 revision) (flutter/flutter#140289)
2023-12-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from c5fc179cf0b3 to 726a137e3f99 (1 revision) (flutter/flutter#140280)
2023-12-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from a8d8fbbcef22 to c5fc179cf0b3 (1 revision) (flutter/flutter#140277)
2023-12-16 leroux_bruno@yahoo.fr Center Floating Snackbar with custom width when direction is RTL (flutter/flutter#140215)
2023-12-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6752398c2f54 to a8d8fbbcef22 (1 revision) (flutter/flutter#140274)
2023-12-16 barpac02@gmail.com Use `SemanticsUpdateBuilder` again, remove all references to temporary `SemanticsUpdateBuilderNew` (flutter/flutter#139942)
2023-12-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7d300e5b9587 to 6752398c2f54 (1 revision) (flutter/flutter#140270)
2023-12-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 832238a3b493 to 7d300e5b9587 (1 revision) (flutter/flutter#140268)
2023-12-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 34d427aa009c to 832238a3b493 (1 revision) (flutter/flutter#140265)
2023-12-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 74e4965a2845 to 34d427aa009c (1 revision) (flutter/flutter#140263)
2023-12-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from ca329dd84207 to 74e4965a2845 (4 revisions) (flutter/flutter#140262)
2023-12-16 xilaizhang@google.com [github actions] minor PR to test latest github actions (flutter/flutter#140252)
2023-12-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6e3a04874be5 to ca329dd84207 (3 revisions) (flutter/flutter#140255)
2023-12-15 polinach@google.com Remove usage of testWidgetsWithLeakTracking. (flutter/flutter#140239)
2023-12-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from a8d861b53db1 to 6e3a04874be5 (1 revision) (flutter/flutter#140244)
2023-12-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from c48b08ac4682 to a8d861b53db1 (1 revision) (flutter/flutter#140240)
2023-12-15 42216813+eliasyishak@users.noreply.github.com Use new `enabledFeature` param for `Analytics` (flutter/flutter#139934)
2023-12-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from db98451b063c to c48b08ac4682 (2 revisions) (flutter/flutter#140236)
2023-12-15 polinach@google.com Reorganize dependencies on leak_tracker. (flutter/flutter#140233)
2023-12-15 chris@bracken.jp [macOS,iOS] CocoaPods recommended version: 1.13.0 (flutter/flutter#135447)
2023-12-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from b36374085c4b to db98451b063c (1 revision) (flutter/flutter#140230)
2023-12-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from e89b7ed8812b to b36374085c4b (1 revision) (flutter/flutter#140228)
2023-12-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 986a6fe198dc to e89b7ed8812b (1 revision) (flutter/flutter#140224)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@goderbauer goderbauer mentioned this pull request Jan 3, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
baf739c Remove usage of testWidgetsWithLeakTracking. (flutter/flutter…
4e082cb 
…#140239)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@polina-c @dnfield