Improving A11y for Flutter Gallery Demos #53616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
commented
Mar 31, 2020
Piinks
commented
Mar 31, 2020
HansMuller
approved these changes
Apr 2, 2020
dev/integration_tests/flutter_gallery/lib/demo/material/bottom_app_bar_demo.dart
Show resolved
Hide resolved
dev/integration_tests/flutter_gallery/lib/demo/material/chip_demo.dart
Outdated
Show resolved
Hide resolved
goderbauer
approved these changes
Apr 2, 2020
|
This pull request is not suitable for automatic merging in its current state.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first of several skip related PRs. I am auditing the codebase for skips that are associated with closed issues, or are no longer relevant.
If any of these skips are still accurate, they will need a new issue attributed to them.
This PR refactors some of the Fluter Gallery demos in order to un-skip tests that were checking if widgets meet A11y guidelines.
Related Issues
#22044
#10830
#16488
#19623
Fixes #21647
Fixes #21651
Tests
Fixed!
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.