Skip to content

Conversation

jonahwilliams
Copy link
Contributor

Description

Allow providing the --enable-experiment flag to the dart analyzer. This supports the eventual null-safety preview.

#52819

@jonahwilliams jonahwilliams added the a: null-safety Support for Dart's null safety feature label Apr 12, 2020
@fluttergithubbot fluttergithubbot added tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Apr 12, 2020

testUsingContext('analyze once supports analyzing null-safe code', () async {
const String contents = '''
int? bar;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is parse failure without the flag

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

_pid,
fakeCommand.stderr,
null, // stdin
fakeCommand.stdin, // stdin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@fluttergithubbot fluttergithubbot merged commit ee43de0 into flutter:master Apr 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: null-safety Support for Dart's null safety feature tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants