Skip to content

Conversation

jonahwilliams
Copy link
Contributor

Reverts #54497

This change has led to a new flake:

01:08 +37 -1: test\run_test.dart: run.dart script exits with code 1 when fails to connect [E]                                                                                                          
  Expected: not <0>
    Actual: <0>
  [ stderr from test process ]
  
  
  
  [ end of stderr ]
  
  [ stdout from test process ]
  
  
  
  ��������������╡ ••• Running task "smoke_test_setup_failure" ••• ╞���������������
  
  
  Executing: C:\b\s\w\ir\k\flutter\bin\cache\dart-sdk\bin\dart --enable-vm-service=0 --no-pause-isolates-on-exit bin/tasks/smoke_test_setup_failure.dart in C:\b\s\w\ir\k\flutter\dev\devicelab
  [smoke_test_setup_failure] [STDOUT] Observatory listening on http://127.0.0.1:58612/1bRsp3TbNHI=/
  "C:\b\s\w\ir\k\flutter\bin\cache\dart-sdk\bin\dart" exit code: 0
  
  
  [ end of stdout ]
  
  package:test_api         expect
  test\run_test.dart 29:7  main.<fn>.expectScriptResult
  

01:08 +37 -1: test\run_test.dart: run.dart script exits with code 1 when results are mixed     

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 12, 2020
@jonahwilliams jonahwilliams requested a review from yjbanov April 12, 2020 20:24
@yjbanov
Copy link
Contributor

yjbanov commented Apr 13, 2020

Darn. The flake was exactly what I was aiming to fix.

@yjbanov
Copy link
Contributor

yjbanov commented Apr 13, 2020

@jonahwilliams where did you see it fail? Cirrus? LUCI?

@jonahwilliams
Copy link
Contributor Author

Landing on red since this is a revert

@jonahwilliams jonahwilliams merged commit e212662 into master Apr 13, 2020
@jonahwilliams jonahwilliams deleted the revert-54497-deflake-run_test2 branch April 13, 2020 18:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants