Allow WIllPopCallback to return null or false to veto the pop. #54640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently any application using a WillPopCallback to veto or allow a pop to take place is required to either return
true
orfalse
. However, a common use case for using the willPop mechanism in routes would be to use the return value from an AlertDialog that is asking the user whether they wanted to continue or not. When a dialog is dismissed by tapping on the background barrier the return value will fromshowDialog
will benull
which will cause the willPop mechanism to fail with an exception.This PR relaxes the interpretation of the return value from
WillPopCallback
to treatnull
the same asfalse
(i.e. veto the pop operation). It will only allow the pop if the callback returnstrue
.Related Issues
Fixes: #51768
Tests
I added a new test that checks for both
null
andfalse
and ensures they are treated the same.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them?