Skip to content

Mark ios_app_with_watch_companion as flaky #54891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2020
Merged

Mark ios_app_with_watch_companion as flaky #54891

merged 1 commit into from
Apr 15, 2020

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Apr 15, 2020

Description

Mark as flaky while I investigate the runtime installed on all the devicelab machines.

Related Issues

#54887
#51126

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 15, 2020
@jmagman jmagman self-assigned this Apr 15, 2020
@jmagman jmagman added the team-infra Owned by Infrastructure team label Apr 15, 2020
@jmagman
Copy link
Member Author

jmagman commented Apr 15, 2020

Merging to green the build.

@jmagman jmagman merged commit c89b634 into flutter:master Apr 15, 2020
@jmagman jmagman mentioned this pull request Apr 15, 2020
Closed
@jmagman jmagman deleted the flaky branch April 15, 2020 19:43
@jmagman
Copy link
Member Author

jmagman commented Apr 15, 2020

Tracking re-enabling with #54892.

christopherfujino
christopherfujino reviewed Apr 15, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For future reference, I believe the process is usually to add devicelab tests as flaky, and then remove the flaky status when it's proven stable.

@jmagman
Copy link
Member Author

jmagman commented Apr 15, 2020

LGTM. For future reference, I believe the process is usually to add devicelab tests as flaky, and then remove the flaky status when it's proven stable.

About a second after I merged it I remembered that detail.

@jmagman jmagman added the platform-ios iOS applications specifically label Aug 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically team-infra Owned by Infrastructure team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmagman @christopherfujino @googlebot @fluttergithubbot