Skip to content

Conversation

pennzht
Copy link
Member

@pennzht pennzht commented Apr 23, 2020

Description

The test flutter_gallery_v2_chrome_run_test is failing, because flutter is not on the PATH on devicelab hosts.
This PR tells the testing machine the location of flutter using a relative path.

Related Issues

Closes #55479

Tests

No tests have been added for this change.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
    • This is a fix; no new documentation was needed.
  • All existing and new tests are passing.
    • flutter_gallery_v2_chrome_run_test.dart is not imported into any other files under devicelab, so this test should not affect other tests.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 23, 2020
@pennzht pennzht changed the title Use relative path for flutter. Use correct path for flutter in flutter_gallery_v2_chrome_run_test.dart Apr 23, 2020
@pennzht pennzht requested a review from jmagman April 23, 2020 19:03
Copy link
Contributor

@rami-a rami-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit f582246 into flutter:master Apr 23, 2020
@pennzht pennzht deleted the path-pr branch April 24, 2020 08:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flutter_gallery_v2_chrome_run_test devicelab test fails

7 participants