Skip to content

[timeline] Sort timeline events before summarizing #55763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2020
Merged

[timeline] Sort timeline events before summarizing #55763

merged 1 commit into from
Apr 27, 2020

Conversation

iskakaushik
Copy link
Contributor

No description provided.

@iskakaushik iskakaushik requested a review from flar April 27, 2020 20:22
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Apr 27, 2020
@iskakaushik iskakaushik requested a review from liyuqian April 27, 2020 20:39
flar
flar approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll be curious to see what impact this has on our benchmark dashboard.

@iskakaushik iskakaushik merged commit 2651681 into flutter:master Apr 27, 2020
@iskakaushik iskakaushik deleted the sort-timeline-events-before-summarizing branch April 27, 2020 21:03
flar
flar requested changes Apr 27, 2020
View reviewed changes
packages/flutter_driver/lib/src/driver/timeline.dart
.toList();

timelineEvents.sort((TimelineEvent e1, TimelineEvent e2) {
return e1.timestampMicros.compareTo(e2.timestampMicros);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried running this on my favorite benchmark and got a null exception here. Apparently not all events have timestamps and so you need to do something special to compare events with null timestamps (null should be sorted as less than everything else, maybe?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like all of the events in the timeline I was processing that had null timestamps were the "thread_name" events at the beginning of the log.

iskakaushik pushed a commit to iskakaushik/flutter that referenced this pull request Apr 27, 2020
Revert "[timeline] Sort timeline events before summarizing (flutter#5…
53d8ee0 
…5763)"

This reverts commit 2651681.
iskakaushik added a commit that referenced this pull request Apr 27, 2020
@iskakaushik
Revert "[timeline] Sort timeline events before summarizing (#55763)" (#…
cb88d2a 
…55769)

This reverts commit 2651681.

Co-authored-by: Kaushik Iska <kaushikiska@google.com>
@iskakaushik
Copy link
Contributor Author

reverted at #55769, will make nulls behave well and re-land.

@flar
Copy link
Contributor

flar commented Apr 27, 2020

Sorry about the premature approval. :(

@kf6gpe kf6gpe mentioned this pull request Apr 30, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@flar flar flar requested changes

@liyuqian liyuqian Awaiting requested review from liyuqian

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iskakaushik @fluttergithubbot @flar @googlebot