ToDo Audit - Material Library+ #55789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
commented
Apr 27, 2020
| }) : assert(data != null), | ||
| super(key: key, child: child); | ||
|
|
||
| // TODO(darrenaustin): remove after this deprecation warning has been on |
There was a problem hiding this comment.
I removed this since the 'Deprecated' below will be culled later on during deprecation reaping. No need for a todo.
packages/flutter/lib/src/material/floating_action_button_location.dart
Outdated
Show resolved
Hide resolved
| // around each button on each side, and the button itself will have 8 | ||
| // pixels internally on each side, yet we want the left edge of the | ||
| // inside of the button to line up with the 24.0 left inset. | ||
| // TODO(ianh): Better magic. See https://github.com/flutter/flutter/issues/4460 |
There was a problem hiding this comment.
Issue was closed unimplemented.
Piinks
commented
Apr 27, 2020
chunhtai
reviewed
Apr 28, 2020
12 tasks
Piinks
commented
Apr 28, 2020
Piinks
commented
Apr 28, 2020
Piinks
commented
Apr 30, 2020
Piinks
commented
Apr 30, 2020
Piinks
commented
Apr 30, 2020
|
@xster do you have any feedback on that curve ToDo? #55789 (comment) |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Piinks
commented
May 6, 2020
Piinks
commented
May 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuing audit of TODOs in the codebase.
This PR removes 12 TODOs, and updates 9 TODOs.
Related Issues
dart-lang/sdk#58600
dart-lang/sdk#59186
#32782
#37333
#48522
#51627
#52114
#56079
#56082
dart-lang/sdk#57782
dart-lang/sdk#10659
dart-lang/sdk#34180
dart-lang/sdk#35520
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.