[flutter_tools] remove flutter view cache #56223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nvm, i misread the code, we waited forever lol. I wonder if instead we should wait for isolate runnable? Otherwise I could patch wait forever back in, seems bad to do polling if we don't need to. |
|
I think I don't quite follow, but waiting forever here sounds in line with the policy against timeouts. |
|
I added back the poll forever logic |
zanderso
reviewed
May 4, 2020
| if (views.isNotEmpty || returnEarly) { | ||
| return views; | ||
| } | ||
| await Future<void>.delayed(delay); |
There was a problem hiding this comment.
This previously had a 'This is taking a long time' message. Should that also be restored, or is this already wrapped in a status spinner thing?
There was a problem hiding this comment.
Ahh, status spinner is a good idea. Let me add that instead of adding a print
|
Status spinner added, tests updated - PTAL |
|
The Linux failure is a flake that I cannot rerun |
jmagman
approved these changes
May 5, 2020
jonahwilliams
pushed a commit
that referenced
this pull request
May 5, 2020
This reverts commit 209bdcb.
jonahwilliams
pushed a commit
that referenced
this pull request
May 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #56194
Remove caching of FlutterView. Perhaps the FlutterView RPC might return an empty list if the VM is not quite up yet? We had some old logic to poll the flutter views RPC for up to 200ms. That doesn't seem like a great approach, so instead we could forgo it entirely and trust that either the views come up before the developer tries to interact, or we crash.
https://github.com/flutter/flutter/blob/stable/packages/flutter_tools/lib/src/vmservice.dart#L1070