Skip to content

Conversation

jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented May 5, 2020

Description

The android attach test is fixed, and the ios/android twc tests are non-flaky. I don't have time to debug the mac twc issue but it seems like it will be difficult remotely so I'm removing from the dashboard for now.

(technically already fixed)

Fixes #55875
Fixes #56322

required_agent_capabilities: ["mac/ios"]
flaky: true

mac_enable_twc:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have a TODO to re-enable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, and moved to correct section

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with an optional nit about leaving a TODO for the removed test.

@fluttergithubbot fluttergithubbot merged commit 82b635e into flutter:master May 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

4 participants