[flutter_tools] Restore base/platform.dart #56410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
approved these changes
May 6, 2020
Done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #7642, the tool's wrapper around
dart:ioPlatformwas pulled out into a separate packagepackage:platform. That package may soon see some breaking changes which are easiest dealt with in the tool by bringing the wrapper back in where it was undersrc/base/platform.dart.In a subsequent PR, I'll update the tool's pubspec.yaml, and run update-packages.
Tests
I added the following tests:
Tests are migrated to the internal wrapper. Added the tests from the package.
Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].