Shard firebase_test_lab_tests

[jmagman]

Description

Split firebase_test_lab_tests into 3 shards, one per integration test.

Related Issues

Fixes #56590

Checklist

• I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
• I signed the [CLA].
• I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
• I read the [Tree Hygiene] wiki page, which explains my responsibilities.
• I updated/added relevant documentation (doc comments with ///).
• All existing and new tests are passing.
• The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

• No, no existing tests failed, so this is not a breaking change.
• Yes, this is a breaking change. If not, delete the remainder of this section.

[jmagman]

Previous to this change, the firebase tests took ~35 minutes. With this change:
firebase_lab_release_smoke_test: 16:38
firebase_lab_abstract_method_smoke_test: 19:36
firebase_lab_android_embedding_v2_smoke_test: 16:43

[Hixie]

please don't do it this way -- just use the same style the rest of the file does
we're trying to keep this file to as rigorously simple a style as we can

[jmagman]

Are you referring to adding a SHARD_TEMPLATE for the environment or pushing the shard numbers down into the test?

[Hixie]

i mean using matrix

[Hixie]

it might be a good idea to move this to test.dart rather than having its own separate shell script.

[jmagman]

Indeed that would be better. I split the difference and dumbed down .cirrus.yml and pushed the subshard -> test logic into test.dart. firebase_testlab.sh still lives, though.

[jmagman]

[Hixie]

I'd really much rather we just duplicate all the text. i think the burden on people who look at this file without knowing Yaml's more obscure features is going to be much greater than the burden on people who have to deal with duplicated text.

[jmagman]

just use the same style the rest of the file

Would you prefer #50306 be reverted? I would guess so based on #50306 (comment).

[Hixie]

Well, that does end up saving a lot of duplication, huh...

Ok, so long as we have just the one mechanism for doing this, I'm good. The syntax you use here is exactly the same as in #50306?

[jmagman]

Yup!
https://github.com/flutter/flutter/blob/master/.cirrus.yml#L573-L583
etc

[Hixie]

It might make sense to do the trick we use elsewhere that verifies that the right number of shards are actually given (by having the last shard be named something like 5_last or something, I forget exactly how we do it).

Up to you.

[Hixie]

If you want real bonus points, maybe add a comment at the top of the file explaining the dark magic? :-)