Skip to content

[flutter_tools] cache-bust in service worker #56786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 16, 2020
Merged

[flutter_tools] cache-bust in service worker #56786

merged 12 commits into from
May 16, 2020

Conversation

jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented May 9, 2020 •
edited
Loading

Description

Prevent HTTP cache from breaking invariants of service worker cache by forcing a new version through no-cache param. Fixes issue where a fetch request for /#/ or other routes would not redirect to index.html

Also adds the functionality required for flutter/packages#150

Fixes #56532

@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 9, 2020
@jonahwilliams
Copy link
Contributor Author

I was thinking about an integration test for this, We spin up a dart server to serve the app and then verify that http requests from it

@jonahwilliams
Copy link
Contributor Author

@yjbanov do you have any advice on debugging why chrome won't start up? I can get these to pass locally with headless:false,but I always get "Exited with unexpected code 0" on headless:true

jonahwilliams
jonahwilliams commented May 11, 2020
View reviewed changes
@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 14, 2020
@jonahwilliams jonahwilliams requested a review from yjbanov May 14, 2020 20:35
yjbanov
yjbanov approved these changes May 15, 2020
View reviewed changes
dev/integration_tests/web/web/index.html Outdated
<script defer src="main.dart.js" type="application/javascript"></script>
<meta content="IE=Edge" http-equiv="X-UA-Compatible">

<title>Flutter Gallery</title>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the gallery, is it?

@jonahwilliams jonahwilliams mentioned this pull request May 16, 2020
Open
@fluttergithubbot fluttergithubbot merged commit 631087d into flutter:master May 16, 2020
@jonahwilliams jonahwilliams deleted the cache_bust_with_sha branch May 16, 2020 22:04
@jonahwilliams jonahwilliams mentioned this pull request May 28, 2020
Closed
@sgehrman

This comment was marked as abuse.

Sign in to view
@jeffaknine
Copy link

I'm having the same issue, can we get a follow up on this? @jonahwilliams

@sachemmark sachemmark mentioned this pull request Aug 31, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[web] should use the version settled in pubspec.yaml

6 participants

@jonahwilliams @fluttergithubbot @sgehrman @jeffaknine @yjbanov @googlebot