Skip to content

Conversation

stuartmorgan-g
Copy link
Contributor

Description

The -S/-B format of specifying source and build directories wasn't added
until 3.13. For 3.10 compatibility, use the older form of having the
working directory as the build directory, and the last argument as the
source directory.

Related Issues

Fixes #57409

Tests

I added the following tests: None; updated existing tests to expect the older command line format.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

The -S/-B format of specifying source and build directories wasn't added
until 3.13. For 3.10 compatibility, use the older form of having the
working directory as the build directory, and the last argument as the
source directory.

Fixes flutter#57409
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 17, 2020
@stuartmorgan-g
Copy link
Contributor Author

I really need to do an end-to-end test with 3.10 to make sure there aren't other compat issues lurking that I missed in writing it, but this fixes the immediate problem. (We also need end-to-end automated testing with an Ubuntu 18.04 image, but that's already on the TODO list.)

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrGreenTea
Copy link

Maybe adding a version check of cmake in doctor could also be helpful?

@stuartmorgan-g
Copy link
Contributor Author

Maybe adding a version check of cmake in doctor could also be helpful?

There is already a version check.

@stuartmorgan-g stuartmorgan-g merged commit f991308 into flutter:master May 18, 2020
@stuartmorgan-g stuartmorgan-g deleted the cmake-3-10-command-fix branch May 18, 2020 16:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Source directory does not exist' building Linux with CMake 3.10

5 participants