Skip to content

Conversation

liyuqian
Copy link
Contributor

This should fix the version issue in the failed test.

Here's the related error in an example failure log

Executing: pub global activate devtools 0.2.5 in /home/flutter/.cocoon/flutter/dev/benchmarks/complex_layout
--
  | 2020-05-20T13:34:55.628211: stdout: Resolving dependencies...
  | 2020-05-20T13:34:56.302033: stderr: The current Dart SDK version is 2.5.2.
  | stderr:
  | stderr: Because devtools >=0.2.5 depends on devtools_server >=0.1.14 which requires SDK version >=2.6.0 <3.0.0, devtools >=0.2.5 is forbidden.
  | stderr: So, because pub global activate depends on devtools 0.2.5, version solving failed.

This should fix the version issue in the failed test.
@liyuqian liyuqian requested a review from dnfield May 20, 2020 23:49
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 20, 2020
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 721927e into flutter:master May 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants