Rename integration test ios_app_with_watch_companion -> ios_app_with_extensions #58458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I re-ran the windows commands test, as it timed out |
christopherfujino
approved these changes
Jun 2, 2020
dev/devicelab/manifest.yaml
Outdated
| ios_app_with_extensions_test: | ||
| description: > | ||
| Checks that an iOS app with a watchOS companion can be build for physical and simulated devices. | ||
| Checks that an iOS app with extensions can be build for physical and simulated devices. |
There was a problem hiding this comment.
Suggested change
| Checks that an iOS app with extensions can be build for physical and simulated devices. | |
| Checks that an iOS app with extensions can be built for physical and simulated devices. |
| @@ -0,0 +1,5 @@ | |||
| # iOS Extensions Test | |||
|
|
|||
| Integration test for to test building iOS app with | |||
There was a problem hiding this comment.
Suggested change
| Integration test for to test building iOS app with | |
| Integration test to test building an iOS app with |
| MTL_FAST_MATH = YES; | ||
| OTHER_LDFLAGS = ""; | ||
| PRODUCT_BUNDLE_IDENTIFIER = com.example.watchCompanionTest.watchkitapp; | ||
| PRODUCT_BUNDLE_IDENTIFIER = io.flutter.extensionTest.watchkitapp; |
There was a problem hiding this comment.
this should probably be dev.flutter.extensionTest.watchkitapp, but that's probably a bigger refactor for another day
|
All tests passed before my spelling tweaks, merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename ios_app_with_watch_companion to something more generic so it can be repurposed for more iOS project extensions.
Related Issues
Will use this test to add a Swift Package integration test in a future PR (#57083)
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change