Add the ability to ignore lines depending on comments #58656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This will be easier to land after #58658 updates the versions (we do it in a weird, lockstep kind of way) |
|
@pasindud the version fixes have landed, you should be able to update and get this working now. Sorry for the delay! |
|
No problem, I have sync'd the PR |
|
Thanks @pasindud , sorry this took a while to get though |
|
👍 Thanks for the help |
jonahwilliams
pushed a commit
that referenced
this pull request
Jun 18, 2020
This reverts commit df02518.
jonahwilliams
pushed a commit
that referenced
this pull request
Jun 19, 2020
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
https://github.com/dart-lang/coverage - 0.14.0 added the ability to be able to ignore coverage depending on comments. // coverage:ignore-line to ignore one line. // coverage:ignore-start and // coverage:ignore-end to ignore range of lines inclusive. // coverage:ignore-file to ignore the whole file.
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
…r#58656)" (flutter#59813) This reverts commit df02518.
8 tasks
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
https://github.com/dart-lang/coverage - 0.14.0 added the ability to be able to ignore coverage depending on comments. // coverage:ignore-line to ignore one line. // coverage:ignore-start and // coverage:ignore-end to ignore range of lines inclusive. // coverage:ignore-file to ignore the whole file.
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…r#58656)" (flutter#59813) This reverts commit df02518.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/dart-lang/coverage - 0.14.0 added the ability to be able to ignore coverage depending on comments.
// coverage:ignore-lineto ignore one line.// coverage:ignore-startand// coverage:ignore-endto ignore range of lines inclusive.// coverage:ignore-fileto ignore the whole file.Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.