Skip to content

Conversation

darrenaustin
Copy link
Contributor

Description

Currently, the highlight used on an InkResponse when it is focused is a circle with a hard coded radius of 35 (Material.defaultSplashRadius). While a good default, it may not be appropriate for all use cases. This PR has the response use the radius parameter for this if it is given. If not it reverts to Material.defaultSplashRadius as normal.

Tests

I added a test 'ink response uses radius for focus highlight' to ink_well_test.dart.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them?

  • No, no existing tests failed, so this is not a breaking change.

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 10, 2020
@darrenaustin darrenaustin changed the title Ink highlight radius Make the InkResponse's focus highlight honor the radius parameter Jun 10, 2020
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@fluttergithubbot fluttergithubbot merged commit cb8562e into flutter:master Jun 10, 2020
@darrenaustin darrenaustin deleted the ink_highlight_radius branch June 10, 2020 20:04
vasilich6107 added a commit to artflutter/whatsup_flutter_june2020 that referenced this pull request Jul 8, 2020
Make the InkResponse's focus highlight honor the radius parameter
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants