Add iOS Podfile migration warning to support federated plugins #59201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
commented
Jun 10, 2020
| const String outOfDatePluginsPodfileConsequence = ''' | ||
| This can cause issues if your application depends on plugins that do not support iOS. | ||
| See https://flutter.dev/docs/development/packages-and-plugins/developing-packages#plugin-platforms for details. | ||
| If you have local Podfile edits you would like to keep, see https://github.com/flutter/flutter/issues/45197 for instructions.'''; |
|
\cc @stuartmorgan |
zanderso
approved these changes
Jun 11, 2020
| return; | ||
| } | ||
|
|
||
| // Previously, the Podfile created a symlink to the cached artifacts engine framework |
There was a problem hiding this comment.
Is there potentially an end-date for these mitigations, or is this code needed forever?
There was a problem hiding this comment.
The primary purpose of #59044 is to move most of this logic into the tool so we can change it without requiring the user to regenerate their Podfile. It imports a new Ruby helper (bleh) from flutter_tools/bin and then calls those helper methods. So, 🤞 this is one of the last migration prompts we ever need (knock on wood as well).
So this particular migration prompt is to get them to generate the new version of the Podfile that imports from the tool. It will be needed long as we want to support projects created in 1.17 that upgrade to latest.
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#59044 moved as much logic as possible from the app Podfile into a ruby script in the tool. The Podfile needs to be regenerated to import and use the new script. Now that the logic is in the tool, app developers won't need to regenerate it when the plugin logic changes.
Related Issues
Part 2 of #59044.
First part of #39659
Tests
cocoapods_test
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change