Reland non-breaking "Add clipBehavior to widgets with clipRect #55977" #59364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" (flutter#58344)" This reverts commit 1d395c5.
|
Non-breaking properties tested on cl/316808440 |
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
…r#55977" (flutter#59364) * Revert "Revert "Add clipBehavior to widgets with clipRect (flutter#55977)" (flutter#58344)" This reverts commit 1d395c5. * Add missed Overflow
This was referenced Jul 13, 2020
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Aug 12, 2020
These widgets are missing from flutter#59364 With this change, developers can use clipBehavior for flutter#59424
liyuqian
added a commit
that referenced
this pull request
Aug 13, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…r#55977" (flutter#59364) * Revert "Revert "Add clipBehavior to widgets with clipRect (flutter#55977)" (flutter#58344)" This reverts commit 1d395c5. * Add missed Overflow
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
These widgets are missing from flutter#59364 With this change, developers can use clipBehavior for flutter#59424
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Sep 10, 2020
This follows flutter#59364 and cl/319911104
liyuqian
added a commit
that referenced
this pull request
Sep 15, 2020
This follows #59364 and cl/319911104 FittedBox is still default to hardEdge clip as new FittedBox is added to Google very quickly. Let's first roll other part of changes into Google first.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of #55977. On top of that, we fixed the Overflow issue to make it non-breaking.
Description
We add
clipBehaviortoEventually, the first 4 of them will be default to
Clip.nonewhile the remaining 6 of them are default toClip.hardEdge.In the current PR, all of them are still default to
Clip.hardEdgeto not break some Google usages. Once we've updated the code inside Google, we'll update the clipBehavior.Related Issues
This is a continuation of #18057, and this fixes #21830
Tests
Unit tests added to each modified widget and render object.
Breaking Change