Skip to content

Don't crash when pubspec isn't a map #59632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2020
Merged

Don't crash when pubspec isn't a map #59632

merged 1 commit into from
Jun 17, 2020

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jun 17, 2020

Description

Validation error when the pubspec is valid YAML, but not a map.

Related Issues

Fixes #59610

Tests

flutter_manifest_test

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 17, 2020
@jmagman jmagman requested a review from jonahwilliams June 17, 2020 02:01
@jmagman jmagman self-assigned this Jun 17, 2020
jonahwilliams
jonahwilliams approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fluttergithubbot fluttergithubbot merged commit b8c64d7 into flutter:master Jun 17, 2020
@zanderso
Copy link
Member

Thanks!

zljj0818 pushed a commit to zljj0818/flutter that referenced this pull request Jun 22, 2020
@jmagman @zljj0818
Don't crash when pubspec isn't a map (flutter#59632)
533033b
@jmagman jmagman deleted the parse-yaml-string branch June 24, 2020 19:35
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@jmagman @mingwandroid
Don't crash when pubspec isn't a map (flutter#59632)
e4c3394
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cast error in flutter manifest yaml parser

5 participants

@jmagman @zanderso @jonahwilliams @googlebot @fluttergithubbot