-
Notifications
You must be signed in to change notification settings - Fork 29.3k
Web macrobenchmark: bench_mouse_region_grid_hover now tests hitTestDuration #60554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fluttergithubbot
merged 8 commits into
flutter:master
from
dkwingsmt:mouse-hittest-web-benchmark
Jul 5, 2020
Merged
Web macrobenchmark: bench_mouse_region_grid_hover now tests hitTestDuration #60554
fluttergithubbot
merged 8 commits into
flutter:master
from
dkwingsmt:mouse-hittest-web-benchmark
Jul 5, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
@yjbanov Can you take a look to see this is a good direction, before I finish the PR with documentation? |
yjbanov
reviewed
Jun 29, 2020
yjbanov
approved these changes
Jul 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It has been discovered that
WidgetRecorder
's frameDuration does not include out-of-frame executions, which is exactly whatbench_mouse_region_grid_hover
wants to test.This PR changes
bench_mouse_region_grid_hover
so that it also measures the duration ofawait _gesture.hover()
ashitTestDuration
.Additionally, this PR changes
FrameRecorder.didStop
, a setter, toFrameRecorder.registerDidStop
, in order to allow multiple frame-end callbacks.With this change, the result of
hitTestDuration
with #59883 is:Related Issues
Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR. There should be at least one issue listed here.
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.