Skip to content

Conversation

CareF
Copy link
Contributor

@CareF CareF commented Jul 2, 2020

Description

TimelineSummary.writeSummaryToFile and TimelineSummary.writeTimelineToFile are async IO method, but in many of our use cases they are not awaited, but rely on zone to await when exit. This PR await them explicitly.

In the unit test case of TimelineSummary they are awaited, so this most likely happened when we switched from sync IO to async IO.

Related Issues

N/A

Tests

N/A

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@CareF CareF added the a: tests "flutter test", flutter_test, or one of our tests label Jul 2, 2020
@CareF CareF requested review from Hixie and yjbanov July 2, 2020 14:39
@CareF CareF self-assigned this Jul 2, 2020
@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 2, 2020
@CareF CareF merged commit c3217da into flutter:master Jul 6, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants