[package_info] add support for macos to package_info plugin #2618

hpoul · 2020-03-23T21:35:31Z

Description

adds macos support to package_info plugin. (similar to firebase_core) moves the objective c implementation file to darwin/Classes and symlinks to ios/Classes and macos/Classes.
add macos example (basically just a flutter create) - i've also added an explicit version code to pubspec.yaml of the example app.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

…ber and added explicit version to example project.

stuartmorgan-g · 2020-03-24T16:56:05Z

I believe the failures here are that you've added a version to the example, and the package version check script is trying to compare your new version to the (non-existent) old version. You'll need to either revert that change to the example's pubspec, or you or someone else will need to fix the script (filtering out example/ directories would probably be the best option)

hpoul · 2020-03-24T19:30:38Z

@stuartmorgan thanks for taking a look. I have removed the version and updated the tests.

The version property actually got me a bit confused.. because on iOS it is a warning if omitted:

Warning: Missing build name (CFBundleShortVersionString).
Warning: Missing build number (CFBundleVersion).
Action Required: You must set a build name and number in the pubspec.yaml file version field before submitting to the App Store.

and even though the pubspec.yaml documentation says "If you omit it, your package is implicitly versioned 0.0.0." - but it seems in the app templates for android it falls back to 1.0. 🤔️

anyway, it seems the package_info/example/ios is not even set up to use the flutter version strings (the iOS Info.plist file specifies it directly instead of referencing FLUTTER_BUILD_NAME/FLUTTER_BUILD_NUMBER) so my test updates weren't even correct 🤦️

stuartmorgan-g · 2020-03-24T19:39:35Z

I suspect this example app's creation predates both the warning, and the iOS version wire-up. If you feel inspired to re-create the example with a current template as a separate PR, that probably wouldn't be a bad idea (assuming the version check script is fixed as well), but it definitely doesn't need to block this.

stuartmorgan-g

The macOS parts all look good to me. It'll need a review from a flutter/plugins owner though.

packages/package_info/CHANGELOG.md

packages/package_info/example/test_driver/package_info_e2e.dart

cyanglaz

LGTM code wise. I didn't look into too much on the generated files.

packages/package_info/example/macos/.gitignore

packages/package_info/example/macos/Runner/AppDelegate.swift

stuartmorgan-g · 2020-04-09T22:49:14Z

@cyanglaz Any idea what's going on with the test failures here? Was there an issue with running tests against stable recently?

cyanglaz · 2020-04-09T23:12:10Z

@stuartmorgan Not sure, im triggering a re-run and let's see what happens

hpoul · 2020-04-29T08:38:45Z

@stuartmorgan @cyanglaz any chance to take another look at this? no idea what the test failures are all about.. thanks..

stuartmorgan-g · 2020-04-29T16:25:54Z

@hpoul Sorry, getting back to this was buried in my todo list. Can you try reverting the ios/ changes in this PR and see if that fixes the issue? I know that was tool-generated rather than something you did manually, but they are the most obvious candidate for having broken iOS tests.

hpoul · 2020-04-30T07:36:27Z

@stuartmorgan thanks, looks like you were right.. :) seems like the master channel made the xcodeproj incompatible with stable.. sounds a bit like flutter/flutter#51453 .. no idea why i actually committed that file

stuartmorgan-g

LGTM

stuartmorgan-g · 2020-05-03T22:17:47Z

@cyanglaz PTAL; you said LGTM above but didn't actually approve, so I'm not sure if you wanted to take a final look once everything was green.

stuartmorgan-g · 2020-05-13T22:44:45Z

@cyanglaz Ping again on this (easy) review.

cyanglaz

LGTM!

stuartmorgan-g · 2020-05-14T03:35:58Z

@hpoul If you can sync with master and resolve the conflicts, I can go ahead and land this :)

hpoul · 2020-05-14T06:39:42Z

@stuartmorgan 👍️ merged with master, let's hope the tests are still happy 🤞️

stuartmorgan-g · 2020-05-14T14:07:27Z

And they are! Landing, thanks for doing this!

* master: (96 commits) Update README.md (flutter#2768) [url_launcher_web] Launch mailto urls in same window in Safari (flutter#2740) update README with enableJavaScript info (flutter#2766) Run publish ci check on master (flutter#2764) [image_picker] Add documentation for Android external storage permissions (flutter#2765) [package_info] add support for macos to package_info plugin (flutter#2618) fixed detach from engine logic (flutter#2759) [url_launcher] Initialize previousAutomaticSystemUiAdjustment in launch (flutter#2757) [google_maps_flutter] add todo on skipped test. (flutter#2752) [google_maps_flutter] use `WaitUntilTouchesEndedPolicy` to fix the cameraIdle not called issue on iOS (flutter#2746) Use Xvfb for Linux desktop tests (flutter#2750) update lower dart bound to 2.1.0 (flutter#2751) [camera] Update lower bound of dart dependency to 2.1.0. (flutter#2749) [battery] update dart deps lower bound to 2.1.0 (flutter#2748) [android_alarm_manager] update dart deps lower bound to 2.1.0 (flutter#2747) [url_launcher] Add web to example app. (flutter#2736) [in_app_purchase] update docs to warn about `completePurchase` (flutter#2739) [video_player] upgraded video_player to use pigeon (flutter#2544) [video_player]: fixed platform_interface unit tests (flutter#2745) [video_player]: added test class to fix video_player unit tests (flutter#2744) ... # Conflicts: # packages/quick_actions/ios/Classes/FLTQuickActionsPlugin.m

hpoul · 2020-06-02T19:10:20Z

Any chance to publish this update to pub? :-) https://pub.dev/packages/package_info is still 0.4.0+18

stuartmorgan-g · 2020-06-02T19:49:42Z

@hpoul Sorry about that, I sound have published when I landed it. Thanks for pinging. 0.4.1 is live.

…2618) Shares implementation with iOS via symlinking. Fixes flutter/flutter#41727

hpoul added 4 commits March 23, 2020 22:00

[package_info] macos support for package_info

35660c8

[package_info] add macos example

efec1e3

[package_info] added macos test, fixed other tests with new build num…

a6e5e43

…ber and added explicit version to example project.

[package_info] bump version number, add changelog.

301a684

hpoul requested review from cyanglaz and matthew-carroll as code owners March 23, 2020 21:35

googlebot added the cla: yes label Mar 23, 2020

hpoul mentioned this pull request Mar 24, 2020

[package_info] Implement macOS support flutter/flutter#41727

Closed

[package_info] remove version name for example

90327f9

stuartmorgan-g reviewed Mar 24, 2020

View reviewed changes

packages/package_info/CHANGELOG.md Outdated Show resolved Hide resolved

packages/package_info/example/test_driver/package_info_e2e.dart Show resolved Hide resolved

[package_info] fix typo in changelog.

ae8f678

cyanglaz reviewed Apr 2, 2020

View reviewed changes

packages/package_info/example/macos/.gitignore Show resolved Hide resolved

packages/package_info/example/macos/Runner/AppDelegate.swift Show resolved Hide resolved

stuartmorgan-g mentioned this pull request Apr 5, 2020

How to reuse identical MacOS and iOS code in a plugin flutter/flutter#52285

Closed

revert example/ios/Runner.xcodeproj/project.pbxproj

08bf9d1

stuartmorgan-g approved these changes May 3, 2020

View reviewed changes

stuartmorgan-g requested a review from cyanglaz May 3, 2020 22:17

cyanglaz approved these changes May 13, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into package_info_macos

ae5d992

stuartmorgan-g merged commit f567f5a into flutter:master May 14, 2020

EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020

[package_info] add support for macos to package_info plugin (flutter#…

b5d55ff

…2618) Shares implementation with iOS via symlinking. Fixes flutter/flutter#41727

ryanheise mentioned this pull request Aug 28, 2020

pub.dev should allow symlinks in package archives dart-lang/pub-dev#3971

Closed

jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020

[package_info] add support for macos to package_info plugin (flutter#…

a24d4ea

…2618) Shares implementation with iOS via symlinking. Fixes flutter/flutter#41727

FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020

[package_info] add support for macos to package_info plugin (flutter#…

a66c3a2

…2618) Shares implementation with iOS via symlinking. Fixes flutter/flutter#41727

[package_info] add support for macos to package_info plugin #2618

[package_info] add support for macos to package_info plugin #2618

Uh oh!

Conversation

hpoul commented Mar 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Checklist

Breaking Change

Uh oh!

stuartmorgan-g commented Mar 24, 2020

Uh oh!

hpoul commented Mar 24, 2020

Uh oh!

stuartmorgan-g commented Mar 24, 2020

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g commented Apr 9, 2020

Uh oh!

cyanglaz commented Apr 9, 2020

Uh oh!

hpoul commented Apr 29, 2020

Uh oh!

stuartmorgan-g commented Apr 29, 2020

Uh oh!

hpoul commented Apr 30, 2020

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented May 3, 2020

Uh oh!

stuartmorgan-g commented May 13, 2020

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented May 14, 2020

Uh oh!

hpoul commented May 14, 2020

Uh oh!

stuartmorgan-g commented May 14, 2020

Uh oh!

hpoul commented Jun 2, 2020

Uh oh!

stuartmorgan-g commented Jun 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hpoul commented Mar 23, 2020 •

edited

Loading