This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[ios_platform_images] Fix crash when parameter extension is null #2654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
suggested changes
Apr 15, 2020
| @@ -1,3 +1,7 @@ | |||
| ## 0.1.0+3 | |||
There was a problem hiding this comment.
Please change this to 0.1.1. The "+N" nomenclature is for changes that don't affect the binary.
There was a problem hiding this comment.
I made the change for you so we can get this landed.
There was a problem hiding this comment.
@gaaclarke 👍 Seems other plugin causes CI red.
gaaclarke
approved these changes
Apr 15, 2020
This was referenced Apr 15, 2020
zhongwuzw
commented
Apr 17, 2020
| /// By default `gestureNavigationEnabled` is false. | ||
| final bool gestureNavigationEnabled; | ||
|
|
||
| /// The value used for the HTTP User-Agent: request header. |
There was a problem hiding this comment.
I don't know wether we need to open another PR to merge this, I think it's trivial. If you think we need, I can revert this. :)
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
…tter#2654) Co-authored-by: Aaron Clarke <aaclarke@google.com>
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
…tter#2654) Co-authored-by: Aaron Clarke <aaclarke@google.com>
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…tter#2654) Co-authored-by: Aaron Clarke <aaclarke@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Crash when
extensionis null.Related Issues
N/A.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?