Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

mariamhas
Copy link
Contributor

@mariamhas mariamhas commented Apr 22, 2020

updates to call out web is also supported for this plugin.
Explicitly tells users not to use the constructor when using the plugin for web.

Related Issues

flutter/flutter#55340

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • [≈ ] No, this is not a breaking change.

updates to call out web is also supported for this plugin.
Explicitly tells users not to use the constructor when using the plugin for web.
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the docs, LGTM!

@ditman ditman changed the title Update Video_player readme [video_player] Update README to mention web support. Apr 22, 2020
@ditman ditman merged commit deb7048 into master Apr 23, 2020
@ditman
Copy link
Member

ditman commented Apr 23, 2020

(Merging on yellow to trigger a cirrus rebuild)

@ditman
Copy link
Member

ditman commented Apr 23, 2020

Ooops, my bad, forgot to mention that we need to bump the version and the CHANGELOG in order for this to be publishable to pub.dev!

PS: @mariamhas fixed it here: #2706

@bparrishMines bparrishMines deleted the ReadmeVideoplayerUpdate branch September 21, 2020 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants