This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] Move core plugin to its own subdir. #2712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` mkdir image_picker git mv -k ./* image_picker ```
|
/cc @kroikie this is step 1 of plugin federation. |
cyanglaz
reviewed
Apr 27, 2020
| @@ -1,3 +1,7 @@ | |||
| ## 0.6.5+3 | |||
There was a problem hiding this comment.
Is this a standard process we update the version even moving to a different folder? I forgot what we have been doing.
There was a problem hiding this comment.
I've definitely done this for other plugins, like google_sign_in 4.0.12
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
* [image_picker] Move to its own subdirectory. ``` mkdir image_picker git mv -k ./* image_picker ``` * Bump version
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
* [image_picker] Move to its own subdirectory. ``` mkdir image_picker git mv -k ./* image_picker ``` * Bump version
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
* [image_picker] Move to its own subdirectory. ``` mkdir image_picker git mv -k ./* image_picker ``` * Bump version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This gives us some space so we can create other directories inside
packages/image_picker.Bump minor version + document the change in CHANGELOG.md
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?