Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

stuartmorgan-g
Copy link
Contributor

Description

Updates the set of packages installed on the Linux desktop Docker image to account for the switch to CMake:

  • Adds the file utility, which is used by the CMake bundling step. The previous set of tools was intended to support both the old Make build and the new CMake build, but this missing tool broke the CMake-based build.
  • Remove make and rsync now that the transition has happened and they are no longer used.

Related Issues

flutter/flutter#52751

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g removed the request for review from robert-ancell May 20, 2020 16:55
@stuartmorgan-g stuartmorgan-g merged commit aa71f39 into flutter:master May 20, 2020
@stuartmorgan-g stuartmorgan-g deleted the linux-ci-cmake-fix branch May 20, 2020 22:53
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
Updates the set of packages installed on the Linux desktop Docker image to account for the switch to CMake:
- Adds the `file` utility, which is used by the CMake bundling step. The previous set of tools was intended to support both the old Make build and the new CMake build, but this missing tool broke the CMake-based build.
- Remove `make` and `rsync` now that the transition has happened and they are no longer used.
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
Updates the set of packages installed on the Linux desktop Docker image to account for the switch to CMake:
- Adds the `file` utility, which is used by the CMake bundling step. The previous set of tools was intended to support both the old Make build and the new CMake build, but this missing tool broke the CMake-based build.
- Remove `make` and `rsync` now that the transition has happened and they are no longer used.
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Updates the set of packages installed on the Linux desktop Docker image to account for the switch to CMake:
- Adds the `file` utility, which is used by the CMake bundling step. The previous set of tools was intended to support both the old Make build and the new CMake build, but this missing tool broke the CMake-based build.
- Remove `make` and `rsync` now that the transition has happened and they are no longer used.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants