Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

cg021
Copy link
Contributor

@cg021 cg021 commented May 20, 2020

Description

Remove the Android directory in the shared_preferences's shared_preferences_web and shared_preferences_macos subdirectories. These are unused implementations and do not need to be included.

Related Issues

flutter/flutter#46304

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@cg021 cg021 requested a review from blasten May 20, 2020 19:57

* Remove Android folder from `shared_preferences_macos`.

## 0.0.1+8
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry- just fixed.

Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cg021 cg021 force-pushed the fix/46304-shared-preferences branch from 63141b8 to 41488b1 Compare May 20, 2020 20:24
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's deleting non-android folder now

@cg021 cg021 force-pushed the fix/46304-shared-preferences branch from d2685f5 to bb9c5e7 Compare May 20, 2020 20:51
@blasten
Copy link

blasten commented May 20, 2020

It also needs to update bump the version of shared_preferences_web

Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cg021 cg021 merged commit 66da13e into flutter:master May 21, 2020
@cg021 cg021 deleted the fix/46304-shared-preferences branch May 21, 2020 03:05
@kmfish
Copy link

kmfish commented May 21, 2020

FAILURE: Build failed with an exception.

  • Where:
    Initialization script '/Users/username/sdk/flutter/packages/flutter_tools/gradle/aar_init_script.gradle' line: 15
  • What went wrong:
    Android property not found.

It will cause build failed when the android directory is removed from the plugin.

@shenguojun
Copy link

when running command "flutter build aar", it will return "Android property not found." error. In the aar_init_script.gradle file , will check if project has property "android". Please don't delete android folder after correct the aar_init_script.gradle.

EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants