-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[shared_preferences] remove android no-op implementation #2779
Conversation
|
||
* Remove Android folder from `shared_preferences_macos`. | ||
|
||
## 0.0.1+8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry- just fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
63141b8
to
41488b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's deleting non-android folder now
d2685f5
to
bb9c5e7
Compare
It also needs to update bump the version of shared_preferences_web |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FAILURE: Build failed with an exception.
It will cause build failed when the android directory is removed from the plugin. |
when running command "flutter build aar", it will return "Android property not found." error. In the aar_init_script.gradle file , will check if project has property "android". Please don't delete android folder after correct the aar_init_script.gradle. |
* remove android folder * version change
* remove android folder * version change
* remove android folder * version change
Description
Remove the Android directory in the shared_preferences's shared_preferences_web and shared_preferences_macos subdirectories. These are unused implementations and do not need to be included.
Related Issues
flutter/flutter#46304
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?