This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[e2e] remove android no-op implementation #2783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasten
reviewed
May 20, 2020
packages/e2e/CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| ## 0.4.2+1 | |||
|
|
|||
| * Remove Android folder from `e2e_macos`. | |||
There was a problem hiding this comment.
The e2e package doesn't need any change. e2e_macos is the only one. @stuartmorgan was this plugin created because e2e wasn't ready to support macos, or is this a federated plugin as well?
There was a problem hiding this comment.
All the macOS implementations in flutter/plugins are federated.
blasten
reviewed
May 21, 2020
packages/e2e/pubspec.yaml
Outdated
| name: e2e | ||
| description: Runs tests that use the flutter_test API as integration tests. | ||
| version: 0.4.2 | ||
| version: 0.4.2+1 |
blasten
suggested changes
May 21, 2020
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
* remove android no-op implementation * remove unnecessary version bump
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
* remove android no-op implementation * remove unnecessary version bump
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
* remove android no-op implementation * remove unnecessary version bump
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the Android directory in the e2e's e2e_macos subdirectory. This is an unused implementation and does not need to be included.
Related Issues
flutter/flutter#46304
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?