Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

ditman
Copy link
Member

@ditman ditman commented May 27, 2020

Description

Publishing v1.1.0 of the platform_interface before the core plugin was ready to accept it (ignoring deprecation warnings) has caused breakage.

This PR locks the version of the platform interface to 1.0.0 so end users of the plugin (still) don't see the deprecation warnings themselves.

Related Issues

#2791

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@ditman ditman requested a review from cyanglaz May 27, 2020 00:16
@ditman ditman self-assigned this May 27, 2020
@ditman
Copy link
Member Author

ditman commented May 27, 2020

This will have to be merged on red, because submit-queue is broken because of the publish of the platform_interface.

This PR should pass analysis checks.

@cyanglaz
Copy link
Contributor

LGTM.

@ditman
Copy link
Member Author

ditman commented May 27, 2020

analyze and publishable are passing. I'm merging this on red to fix the CI.

@ditman ditman merged commit 2ab4bc8 into flutter:master May 27, 2020
@ditman ditman deleted the pin-image-picker-interface-version branch May 27, 2020 00:30
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants