feat: Upgrade Tensorboard from v1beta1 to v1#849
Merged
Conversation
yfang1
reviewed
Nov 17, 2021
yfang1
approved these changes
Nov 17, 2021
morgandu
approved these changes
Nov 17, 2021
Contributor
morgandu
left a comment
There was a problem hiding this comment.
All changes look good, only have a question on Mock fail.
| state=gca_job_state_compat.JobState.JOB_STATE_PENDING, | ||
| version="v1beta1", | ||
| ) | ||
| create_custom_job_mock.side_effect = RuntimeError("Mock fail") |
Contributor
There was a problem hiding this comment.
What is this "Mock fail" side effect for?
Member
Author
There was a problem hiding this comment.
This seems to be git diff surfacing the change in a confusing way.
create_custom_job_mock_fail hasn't changed, reference line 263 on the previous version. It's used to test that we handle failure from the service.
create_custom_job_v1beta1_mock was changed to create_custom_job_mock_with_tensorboard above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aiplatform.Tensorboard