Skip to content

feat: support date_series.astype("string[pyarrow]") to cast DATE to STRING #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2023
Merged

feat: support date_series.astype("string[pyarrow]") to cast DATE to STRING #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bigframes/dtypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ def cast_ibis_value(
),
ibis_dtypes.float64: (ibis_dtypes.string, ibis_dtypes.int64),
ibis_dtypes.string: (ibis_dtypes.int64, ibis_dtypes.float64),
ibis_dtypes.date: (),
ibis_dtypes.date: (ibis_dtypes.string,),
ibis_dtypes.Decimal(precision=38, scale=9): (ibis_dtypes.float64,),
ibis_dtypes.Decimal(precision=76, scale=38): (ibis_dtypes.float64,),
ibis_dtypes.time: (),
Expand Down
1 change: 1 addition & 0 deletions tests/system/small/test_series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2498,6 +2498,7 @@ def test_mask_custom_value(scalars_dfs):
# with timezone conversions, so we'll allow it.
("timestamp_col", pd.ArrowDtype(pa.timestamp("us"))),
("datetime_col", pd.ArrowDtype(pa.timestamp("us", tz="UTC"))),
("date_col", "string[pyarrow]"),
# TODO(bmil): fix Ibis bug: BigQuery backend rounds to nearest int
# ("float64_col", "Int64"),
# TODO(bmil): decide whether to fix Ibis bug: BigQuery backend
Expand Down