fix: make to_pandas override enable_downsampling when sampling_method is manually set. #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is manually set.
jiaxunwu
requested changes
Nov 14, 2023
bigframes/core/blocks.py
Outdated
| ) -> Tuple[pd.DataFrame, int, bigquery.QueryJob]: | ||
| """Run query and download results as a pandas DataFrame. Return the total number of results as well.""" | ||
| # TODO(swast): Allow for dry run and timeout. | ||
| enable_downsampling = bigframes.options.sampling.enable_downsampling |
There was a problem hiding this comment.
Can you put code together for the same logic?
For example,
enable_downsampling = sampling_method is not None or bigframes.options.sampling.enable_downsampling
| if random_state is None: | ||
| random_state = bigframes.options.sampling.random_state | ||
|
|
||
| sampling_method = sampling_method.lower() |
There was a problem hiding this comment.
Can you put sampling_method logic together?
… is manually set.
GarrettWu
reviewed
Nov 16, 2023
| else bigframes.options.sampling.enable_downsampling | ||
| ) | ||
|
|
||
| max_download_size = ( |
There was a problem hiding this comment.
Nit: less code:
max_download_size = max_download_size or bigframes.options.sampling.max_download_size
… is manually set.
GarrettWu
approved these changes
Nov 22, 2023
jiaxunwu
approved these changes
Nov 28, 2023
Genesis929
added a commit
that referenced
this pull request
Dec 12, 2023
… is manually set. (#200) * fix: make to_pandas override enable_downsampling when sampling_method is manually set. * fix: make to_pandas override enable_downsampling when sampling_method is manually set. * fix: make to_pandas override enable_downsampling when sampling_method is manually set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… is manually set.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes b/310741105