Skip to content

feat: add ml.preprocessing.MaxAbsScaler #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 25, 2023
Merged

feat: add ml.preprocessing.MaxAbsScaler #56

merged 6 commits into from
Sep 25, 2023

Conversation

GarrettWu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 22, 2023
@GarrettWu GarrettWu marked this pull request as ready for review September 25, 2023 17:07
@GarrettWu GarrettWu requested review from a team as code owners September 25, 2023 17:07
@GarrettWu GarrettWu assigned GarrettWu, shobsi and ashleyxuu and unassigned GarrettWu Sep 25, 2023
@GarrettWu GarrettWu removed the request for review from milkshakeiii September 25, 2023 17:08
ashleyxuu
ashleyxuu reviewed Sep 25, 2023
View reviewed changes
@GarrettWu GarrettWu requested a review from shobsi September 25, 2023 17:50
@GarrettWu GarrettWu assigned GarrettWu and unassigned shobsi and ashleyxuu Sep 25, 2023
ashleyxuu
ashleyxuu approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@ashleyxuu ashleyxuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GarrettWu GarrettWu merged commit 14b262b into main Sep 25, 2023
@GarrettWu GarrettWu deleted the garrettwu-ml-preprocessing branch September 25, 2023 21:33
@release-please release-please bot mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shobsi shobsi Awaiting requested review from shobsi

1 more reviewer

@ashleyxuu ashleyxuu ashleyxuu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@GarrettWu GarrettWu

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GarrettWu @ashleyxuu @shobsi