chore: configure BUILD_SPECIFIC_GCLOUD_PROJECT for samples CI#148
Merged
chore: configure BUILD_SPECIFIC_GCLOUD_PROJECT for samples CI#148
Conversation
https://github.com/googleapis/python-talent/blob/ef045e8eb348db36d7a2a611e6f26b11530d273b/samples/snippets/noxfile_config.py#L27-L32 `BUILD_SPECIFIC_GCLOUD_PROJECT` is an alternate project used for sample tests that do poorly with concurrent runs on the same project. Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Wed Sep 30 13:06:03 2020 -0600 Source-Repo: googleapis/synthtool Source-Sha: 9b0da5204ab90bcc36f8cd4e5689eff1a54cc3e4 Source-Link: googleapis/synthtool@9b0da52
tseaver
reviewed
Oct 7, 2020
Contributor
tseaver
left a comment
There was a problem hiding this comment.
AFAICS, none of the samples/*/noxfile.py files actually use this envvar: it is present only in commented-out options:
$ git grep -B 1 BUILD_SPECIFIC | tee /tmp/foo.bar
samples/beam/noxfile.py- # An envvar key for determining the project id to use. Change it
samples/beam/noxfile.py: # to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a
--
samples/beam/noxfile.py- 'gcloud_project_env': 'GOOGLE_CLOUD_PROJECT',
samples/beam/noxfile.py: # 'gcloud_project_env': 'BUILD_SPECIFIC_GCLOUD_PROJECT',
--
samples/hello/noxfile.py- # An envvar key for determining the project id to use. Change it
samples/hello/noxfile.py: # to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a
--
samples/hello/noxfile.py- 'gcloud_project_env': 'GOOGLE_CLOUD_PROJECT',
samples/hello/noxfile.py: # 'gcloud_project_env': 'BUILD_SPECIFIC_GCLOUD_PROJECT',
--
samples/hello_happybase/noxfile.py- # An envvar key for determining the project id to use. Change it
samples/hello_happybase/noxfile.py: # to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a
--
samples/hello_happybase/noxfile.py- 'gcloud_project_env': 'GOOGLE_CLOUD_PROJECT',
samples/hello_happybase/noxfile.py: # 'gcloud_project_env': 'BUILD_SPECIFIC_GCLOUD_PROJECT',
--
samples/instanceadmin/noxfile.py- # An envvar key for determining the project id to use. Change it
samples/instanceadmin/noxfile.py: # to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a
--
samples/instanceadmin/noxfile.py- 'gcloud_project_env': 'GOOGLE_CLOUD_PROJECT',
samples/instanceadmin/noxfile.py: # 'gcloud_project_env': 'BUILD_SPECIFIC_GCLOUD_PROJECT',
--
samples/metricscaler/noxfile.py- # An envvar key for determining the project id to use. Change it
samples/metricscaler/noxfile.py: # to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a
--
samples/metricscaler/noxfile.py- 'gcloud_project_env': 'GOOGLE_CLOUD_PROJECT',
samples/metricscaler/noxfile.py: # 'gcloud_project_env': 'BUILD_SPECIFIC_GCLOUD_PROJECT',
--
samples/quickstart/noxfile.py- # An envvar key for determining the project id to use. Change it
samples/quickstart/noxfile.py: # to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a
--
samples/quickstart/noxfile.py- 'gcloud_project_env': 'GOOGLE_CLOUD_PROJECT',
samples/quickstart/noxfile.py: # 'gcloud_project_env': 'BUILD_SPECIFIC_GCLOUD_PROJECT',
--
samples/quickstart_happybase/noxfile.py- # An envvar key for determining the project id to use. Change it
samples/quickstart_happybase/noxfile.py: # to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a
--
samples/quickstart_happybase/noxfile.py- 'gcloud_project_env': 'GOOGLE_CLOUD_PROJECT',
samples/quickstart_happybase/noxfile.py: # 'gcloud_project_env': 'BUILD_SPECIFIC_GCLOUD_PROJECT',
--
samples/snippets/filters/noxfile.py- # An envvar key for determining the project id to use. Change it
samples/snippets/filters/noxfile.py: # to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a
--
samples/snippets/filters/noxfile.py- 'gcloud_project_env': 'GOOGLE_CLOUD_PROJECT',
samples/snippets/filters/noxfile.py: # 'gcloud_project_env': 'BUILD_SPECIFIC_GCLOUD_PROJECT',
--
samples/snippets/reads/noxfile.py- # An envvar key for determining the project id to use. Change it
samples/snippets/reads/noxfile.py: # to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a
--
samples/snippets/reads/noxfile.py- 'gcloud_project_env': 'GOOGLE_CLOUD_PROJECT',
samples/snippets/reads/noxfile.py: # 'gcloud_project_env': 'BUILD_SPECIFIC_GCLOUD_PROJECT',
--
samples/snippets/writes/noxfile.py- # An envvar key for determining the project id to use. Change it
samples/snippets/writes/noxfile.py: # to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a
--
samples/snippets/writes/noxfile.py- 'gcloud_project_env': 'GOOGLE_CLOUD_PROJECT',
samples/snippets/writes/noxfile.py: # 'gcloud_project_env': 'BUILD_SPECIFIC_GCLOUD_PROJECT',
--
samples/tableadmin/noxfile.py- # An envvar key for determining the project id to use. Change it
samples/tableadmin/noxfile.py: # to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a
--
samples/tableadmin/noxfile.py- 'gcloud_project_env': 'GOOGLE_CLOUD_PROJECT',
samples/tableadmin/noxfile.py: # 'gcloud_project_env': 'BUILD_SPECIFIC_GCLOUD_PROJECT',
tseaver
approved these changes
Oct 23, 2020
kolea2
approved these changes
Nov 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/754b31d4-619a-44bd-8949-623b99df0621/targets
Source-Link: googleapis/synthtool@9b0da52