Conversation
tswast
reviewed
Nov 18, 2020
| cluster.reload() | ||
|
|
||
| _nonzero_node_count = RetryInstanceState( | ||
| instance_predicate=lambda c: c.serve_nodes > 0, |
Contributor
There was a problem hiding this comment.
Due to the way that Bigtable assigns keys to be served by various nodes, I'm pretty sure that the minimum number of nodes per instance is 1, not 0.
Contributor
Author
There was a problem hiding this comment.
When initially creating an instance / cluster, the node count can be returned as 0: see the failure output for #159.
tswast
approved these changes
Nov 23, 2020
kolea2
approved these changes
Nov 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #108
Closes #159