Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
kolea2
requested changes
Feb 16, 2022
google/cloud/bigtable/cluster.py
Outdated
| :data:`google.cloud.bigtable.enums.Cluster.State.DISABLED`. | ||
|
|
||
| :type min_serve_nodes: int | ||
| :param min_serve_nodes: (Optional) The minimum number of nodes in the cluster. Must be |
Collaborator
There was a problem hiding this comment.
I would reword this slightly to point out that this is a setting for autoscaling. Something like:
The miniumum number of nodes to be set in the cluster for autoscaling. Must be 1 or greater ...
13646ed to
7b3e3bf
Compare
kolea2
reviewed
Feb 24, 2022
Collaborator
kolea2
left a comment
There was a problem hiding this comment.
lgtm after two small docs comments!
google/cloud/bigtable/cluster.py
Outdated
| and not self.cpu_utilization_percent | ||
| ): | ||
| raise ValueError( | ||
| "Must specify either serve_nodes or all of the autoscaling configurations." |
Collaborator
There was a problem hiding this comment.
maybe list the configurations here for convenience?
google/cloud/bigtable/cluster.py
Outdated
| ) | ||
| ): | ||
| raise ValueError( | ||
| "All of autoscaling configurations must be specified at the same time." |
kolea2
requested changes
Feb 24, 2022
| alt_cluster.reload() | ||
| assert alt_cluster.min_serve_nodes == new_min_serve_nodes | ||
| assert alt_cluster.max_serve_nodes == new_max_serve_nodes | ||
| assert alt_cluster.cpu_utilization_percent == new_cpu_utilization_percent |
Collaborator
There was a problem hiding this comment.
let's add one more test case in which only one field is updated.
Contributor
Author
There was a problem hiding this comment.
I've added such test below (line 691)
kolea2
approved these changes
Mar 2, 2022
- Add the parameters min_serve_nodes, max_serve_nodes, and cpu_utilization_percent - Create disable_autoscaling function - Update documentation and tests
- Unittest fixes
- System test fixes and add new test fixtures
Update docstring. Add test cases.
Update test suite accordingly.
e8aecfe to
3f093f8
Compare
kolea2
approved these changes
Mar 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕