Updated samples with etag support#130
Updated samples with etag support#130leahecole merged 1 commit intogoogleapis:masterfrom gwhitehawk:master
Conversation
|
Here is the summary of changes. You are about to add 5 region tags.
This comment is generated by snippet-bot.
|
|
It seems like lint and the tests are failing - @gwhitehawk please feel free to ping me if you need help debugging these failures from the Python side. I'm not a secret manager expert but can give general python samples advice :) @sethvargo if you can just give this glance and make sure everything seems appropriately "secret-manager-y" that would also be appreciated |
|
Thanks for pointing out the problems - I fixed the import issues. Still haven't run unit tests - I can't set up authentication with keys for my service account (as an internal). Can you please re-apply kokoro force-run label? |
|
@leahecole Seth seemed to appprove but not sure whether he has permission to write. Could you please take another look at the changes? Thanks. |
|
This is ready for re-review. I set up external non-google project and ran tests locally. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #129 🦕