Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Updated samples with etag support#130

Merged
leahecole merged 1 commit intogoogleapis:masterfrom
gwhitehawk:master
Jul 20, 2021
Merged

Updated samples with etag support#130
leahecole merged 1 commit intogoogleapis:masterfrom
gwhitehawk:master

Conversation

@gwhitehawk
Copy link
Contributor

@gwhitehawk gwhitehawk commented Jun 11, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [x ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • [x ] Code coverage does not decrease (if any source code was changed)
  • [x ] Appropriate docs were updated (if necessary)

Fixes #129 🦕

@gwhitehawk gwhitehawk requested a review from a team as a code owner June 11, 2021 19:44
@gwhitehawk gwhitehawk requested review from leahecole and removed request for a team June 11, 2021 19:44
@snippet-bot
Copy link

snippet-bot bot commented Jun 11, 2021

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2021
@product-auto-label product-auto-label bot added api: secretmanager Issues related to the googleapis/python-secret-manager API. samples Issues that are directly related to samples. labels Jun 11, 2021
@parthea parthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2021
@leahecole
Copy link
Contributor

It seems like lint and the tests are failing - @gwhitehawk please feel free to ping me if you need help debugging these failures from the Python side. I'm not a secret manager expert but can give general python samples advice :)

@sethvargo if you can just give this glance and make sure everything seems appropriately "secret-manager-y" that would also be appreciated

@gwhitehawk
Copy link
Contributor Author

Thanks for pointing out the problems - I fixed the import issues. Still haven't run unit tests - I can't set up authentication with keys for my service account (as an internal). Can you please re-apply kokoro force-run label?

@gwhitehawk
Copy link
Contributor Author

@leahecole Seth seemed to appprove but not sure whether he has permission to write. Could you please take another look at the changes? Thanks.

@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2021
@gwhitehawk
Copy link
Contributor Author

This is ready for re-review. I set up external non-google project and ran tests locally.

@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2021
@leahecole leahecole added the automerge Merge the pull request once unit tests and other checks pass. label Jul 20, 2021
@leahecole leahecole merged commit ee4e1bb into googleapis:master Jul 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: secretmanager Issues related to the googleapis/python-secret-manager API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update code samples with examples using etags

5 participants

Comments