UI improvements for older iPhones#4652
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates onboarding SwiftUI layouts to behave better on smaller/older iPhones, focusing on title wrapping and bottom action spacing.
Changes:
- Adjusted
BaseOnboardingViewbottom action area padding to add space on non-Catalyst builds. - Allowed the Welcome screen header to grow vertically (wrap) instead of being constrained to a single line height.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
Sources/App/Onboarding/Views/BaseOnboardingView.swift |
Tweaks bottom action padding inside the bottom safeAreaInset to improve spacing near the bottom edge. |
Sources/App/Onboarding/Steps/Welcome/OnboardingWelcomeView.swift |
Adds fixedSize to the welcome header to support multi-line titles on smaller screens. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4652 +/- ##
=======================================
Coverage ? 43.98%
=======================================
Files ? 280
Lines ? 17021
Branches ? 0
=======================================
Hits ? 7487
Misses ? 9534
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes