fix: compile log without base as natural log#12000
Open
BharatDeva wants to merge 1 commit into
Open
Conversation
NickCrews
reviewed
May 9, 2026
NickCrews
reviewed
May 9, 2026
Contributor
|
Thanks @BharatDeva this looks pretty good! Just two comments. Once you reply, and CI passes, I will merge. |
fdf43a8 to
52bcfdb
Compare
Contributor
|
Thanks! Looks like this just needs a tiny adjustment to get risingwave to pass and then should be good! It looks to me like we should compile this to LN(arg)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes
.log()without an explicit base so it is treated as natural log instead of passing a missing base through asNULL.The issue is visible in Snowflake SQL generation, where
table.value.log()compiled toLOG(NULL, value), and in Polars execution, where the result came back asNaN. This change checks the original operation (op.base) when deciding whether a base was provided, instead of relying on the already-translated backend argument.This also updates the Polars compiler to call
arg.log()for the natural-log case and adds focused regression coverage for Snowflake SQL generation and Polars execution.Issues closed
Testing