-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Description
Prerequisites
- I have read the Contributing Guidelines.
- I agree to follow the Code of Conduct.
- I have searched for existing issues that already report this problem, without success.
Ionic Framework Version
v8.x
Current Behavior
Before @ionic/vue
8.4.4
, both long forms and short forms of events worked; now only short forms work:
So, for example, didPresent
works(gets triggered), but ionModalDidPresent
doesn't.
Expected Behavior
In the expected scenario(as per docs), both short and long versions of events should be emitted, but it is probably best to remove the long-form events.
Steps to Reproduce
Go to: https://stackblitz.com/~/github.com/andrei0x309/ionic-vue-modal-event-bug
Observe ionModalDidPresent
is not emitted when @ionic/vue > 8.4.3
Code Reproduction URL
https://github.com/andrei0x309/ionic-vue-modal-event-bug
Ionic Info
Ionic:
Ionic CLI : 7.2.1 (C:\Users\andrei0x309\AppData\Roaming\npm\node_modules@ionic\cli)
Ionic Framework : @ionic/vue 8.7.2
Capacitor:
Capacitor CLI : 7.4.2
@capacitor/android : not installed
@capacitor/core : 7.4.2
@capacitor/ios : not installed
Utility:
cordova-res : 0.15.4
native-run : 2.0.1
System:
NodeJS : v22.13.1 (C:\Program Files\nodejs\node.exe)
npm : 10.8.1
OS : Windows 10
Additional Information
If deleting long forms of events is acceptable, I can make a PR to update that, it would be a breaking change but it's far better than having some events that don't trigger, because IDEs will indicate that those events don't exist, and devs can fix that very easy by using the "short form" which should become the only form. ( Docs will also be updated)
The problem started with this PR: 11554a5
But I don't see anything wrong with it, might be because of stenciljs vue output pkg