Skip to content

Add data objects#17

Merged
marph91 merged 8 commits into
masterfrom
add-data-objects
Dec 29, 2022
Merged

Add data objects#17
marph91 merged 8 commits into
masterfrom
add-data-objects

Conversation

@marph91
Copy link
Copy Markdown
Owner

@marph91 marph91 commented Dec 29, 2022

Main difference for users is to use note.id instead of note["id"].

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 29, 2022

Unit Test Results

67 tests   - 1   64 ✔️  - 1   20s ⏱️ +4s
12 suites ±0     3 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 7e5599d. ± Comparison against base commit f6be54f.

This pull request removes 1 test.
test.test_api.Helper ‑ test_is_timestamp_valid

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 29, 2022

Codecov Report

Merging #17 (7e5599d) into master (f6be54f) will decrease coverage by 0.88%.
The diff coverage is 97.65%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   98.98%   98.10%   -0.89%     
==========================================
  Files           2        3       +1     
  Lines         198      370     +172     
==========================================
+ Hits          196      363     +167     
- Misses          2        7       +5     
Impacted Files Coverage Δ
joppy/api.py 97.90% <96.29%> (-1.07%) ⬇️
joppy/data_types.py 98.28% <98.28%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marph91 marph91 merged commit b53659e into master Dec 29, 2022
@marph91 marph91 mentioned this pull request Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants