Skip to content

Make classes final and bump linters#72

Closed
a-menshchikov wants to merge 1 commit into
nbgrp:2.1from
a-menshchikov:finals_lints
Closed

Make classes final and bump linters#72
a-menshchikov wants to merge 1 commit into
nbgrp:2.1from
a-menshchikov:finals_lints

Conversation

@a-menshchikov
Copy link
Copy Markdown
Member

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (2.1@cbf58a8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...pendencyInjection/Security/Factory/SamlFactory.php 75.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/Controller/AssertionConsumerService.php 0.00% <ø> (ø)
src/Controller/Login.php 100.00% <ø> (ø)
src/Controller/Logout.php 0.00% <ø> (ø)
src/Controller/Metadata.php 100.00% <ø> (ø)
...ncyInjection/Compiler/AuthRegistryCompilerPass.php 100.00% <100.00%> (ø)
...cyInjection/Compiler/EntityManagerCompilerPass.php 100.00% <100.00%> (ø)
src/DependencyInjection/Configuration.php 100.00% <100.00%> (ø)
...DependencyInjection/NbgrpOneloginSamlExtension.php 100.00% <100.00%> (ø)
.../Security/UserProvider/SamlUserProviderFactory.php 100.00% <100.00%> (ø)
src/Idp/IdpResolver.php 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbf58a8...bce437a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant