Skip to content

Batch update#73

Merged
a-menshchikov merged 1 commit into
1.4from
linters_backport
Sep 22, 2025
Merged

Batch update#73
a-menshchikov merged 1 commit into
1.4from
linters_backport

Conversation

@a-menshchikov
Copy link
Copy Markdown
Member

  • Backport requestedAuthnContextComparison setting from 2.0 branch
  • Use auditor v0.31 and fix code

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 21, 2025

Codecov Report

❌ Patch coverage is 96.92308% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.07%. Comparing base (32f84dd) to head (b4adb1f).
⚠️ Report is 5 commits behind head on 1.4.

Files with missing lines Patch % Lines
...pendencyInjection/Security/Factory/SamlFactory.php 66.66% 1 Missing ⚠️
src/EventListener/Security/SamlLogoutListener.php 88.88% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/Controller/Login.php 100.00% <100.00%> (ø)
...ncyInjection/Compiler/AuthRegistryCompilerPass.php 100.00% <100.00%> (ø)
...cyInjection/Compiler/EntityManagerCompilerPass.php 100.00% <100.00%> (ø)
...ndencyInjection/Compiler/ProxyVarsCompilerPass.php 80.00% <100.00%> (ø)
src/DependencyInjection/Configuration.php 100.00% <100.00%> (ø)
...DependencyInjection/NbgrpOneloginSamlExtension.php 100.00% <100.00%> (ø)
.../Security/UserProvider/SamlUserProviderFactory.php 100.00% <100.00%> (ø)
src/Idp/IdpResolver.php 100.00% <100.00%> (ø)
src/Onelogin/AuthArgumentResolver.php 92.30% <100.00%> (ø)
src/Onelogin/AuthRegistry.php 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c17179...b4adb1f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@a-menshchikov a-menshchikov force-pushed the linters_backport branch 2 times, most recently from 374f856 to 73e9726 Compare September 22, 2025 15:45
- Backport requestedAuthnContextComparison setting from 2.0 branch
- Use auditor v0.31 and fix code
@a-menshchikov a-menshchikov merged commit 0ade7b8 into 1.4 Sep 22, 2025
8 of 11 checks passed
@a-menshchikov a-menshchikov deleted the linters_backport branch September 22, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant